Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use updated enumeration pattern #52

Closed
Denz1994 opened this issue Jan 7, 2019 · 2 comments
Closed

Use updated enumeration pattern #52

Denz1994 opened this issue Jan 7, 2019 · 2 comments
Assignees
@Denz1994
Labels
status:in-progress

Comments

@Denz1994
Copy link
Contributor

Denz1994 commented Jan 7, 2019 •
edited
Loading

As part of developer core hour meeting on 01/07/19:

From the Enumerations section of https://github.com/phetsims/phet-info/blob/master/doc/phet-software-design-patterns.md, we should be using rich enumerations when appropriate. Using the Object.freeze(Enumeration) is a pattern we should move away from.

Quick scan: ForcesModeChoice.js, SimSpeedChoice.js, and SceneModeChoice.js should be reviewed for this change.
@Denz1994 Denz1994 self-assigned this Jan 7, 2019
Denz1994 added a commit to phetsims/masses-and-springs that referenced this issue Jan 9, 2019
@Denz1994
Using Enumeration() instead of Object.freeze pattern phetsims/masses-…
81656f5 
…and-springs-basics#52
@Denz1994
Copy link
Contributor Author

Denz1994 commented Jan 9, 2019

The pattern has been updated to use Enumeration.js. There is still ongoing discussion about how to best proceed with this convention in phetsims/phet-core#53. I'll await the decision there before closing.

Denz1994 added a commit to phetsims/masses-and-springs that referenced this issue Jan 16, 2019
@Denz1994
Update SceneModeChoice.js phetsims/masses-and-springs-basics#52
f9bdbd3
Denz1994 added a commit to phetsims/masses-and-springs that referenced this issue Jan 16, 2019
@Denz1994
Update SimSpeedChoice.js phetsims/masses-and-springs-basics#52
a98a024
Denz1994 added a commit to phetsims/masses-and-springs that referenced this issue Jan 16, 2019
@Denz1994
Update ForcesModeChoice.js phetsims/masses-and-springs-basics#52
d7a0a3a
Denz1994 added a commit to phetsims/masses-and-springs that referenced this issue Jan 16, 2019
@Denz1994
Lint fix. phetsims/masses-and-springs-basics#52
ef405b3
@Denz1994
Copy link
Contributor Author

Enumerations updated as described in by doc convention. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Denz1994 Denz1994

Labels
status:in-progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Denz1994