Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-axis forgiveness #44

Open
Tracked by #937
KatieWoe opened this issue Nov 19, 2018 · 9 comments
Open
Tracked by #937

X-axis forgiveness #44

KatieWoe opened this issue Nov 19, 2018 · 9 comments

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#220
Design question. When dragging masses on the springs down I've often had the masses come off the spring. I know there is a balance between making sure the mass stays on when wanted and comes off when wanted, but I was wondering if keeping the mass on the spring for a little bit more of the x direction might feel better.

@KatieWoe KatieWoe added the type:question Further information is requested label Nov 19, 2018
@Denz1994
Copy link
Contributor

This the RELEASE_DISTANCE can be adjusted fairly easily, so I will leave this up to @arouinfar to review and determine if adjustments need to be made.

@Denz1994 Denz1994 removed their assignment Nov 19, 2018
@arouinfar
Copy link
Contributor

@Denz1994 let's bump RELEASE_DISTANCE up to 0.12.

@arouinfar arouinfar assigned Denz1994 and unassigned arouinfar Nov 19, 2018
@Denz1994
Copy link
Contributor

Denz1994 commented Nov 19, 2018

The RELEASE_DISTANCE has been increased. This will affect MAS and MASB so it should be reviewed in both sims. This change should be included in the next MAS maintenance release.

Assigning to @arouinfar to review.

@arouinfar
Copy link
Contributor

Looks good to me @Denz1994!

@KatieWoe, how's master feeling to you?

@arouinfar arouinfar assigned KatieWoe and unassigned arouinfar Nov 19, 2018
@KatieWoe
Copy link
Contributor Author

I think it feels better. Give me a chance to check on iPad really quick.

@KatieWoe
Copy link
Contributor Author

I think I like it a bit better, but I could also see an argument being made that the masses are harder to take off the spring, though not much. @Denz1994 I'll leave it to your discretion.

@Denz1994
Copy link
Contributor

I'll keep the increase to the RELEASE_DISTANCE. I've run into similar problems with accidentally removing a mass when fully extending the spring. Thanks for the input @KatieWoe.

This change should also be included in the next Masses and Springs maintenance release and will mark as such.

@KatieWoe
Copy link
Contributor Author

When looking at dev.1 the spring behavior being wrong interfered with testing. On master I noticed that the distance to the left of a spring the mass was released was different from the distance to the right of the spring.

@jbphet
Copy link
Contributor

jbphet commented Jul 20, 2023

Unassigning and marking as "blocks-sim-publication" since the republication of this sim has been deprioritized for now. This should be addressed (at least to some degree) before republishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants