Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VoicingPanelSection for Tier 1 Voicing #1002

Open
jessegreenberg opened this issue Dec 16, 2024 · 3 comments
Open

Change VoicingPanelSection for Tier 1 Voicing #1002

jessegreenberg opened this issue Dec 16, 2024 · 3 comments

Comments

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Dec 16, 2024

PhET is considering a "Tier 1" Voicing feature, which is a subset of the full Voicing feature. We need to change the Preferences Dialog content slightly for publishing with "Tier 1".

"Tier 1" includes everything excpet for object and context responses. So the only change we need to make is to hide the checkboxes that enable those responses.

This content:

  • "Voice object details and changes"
  • "Voice surrounding context changes"

Needs to be hidden.

Fro phetsims/trig-tour#108.

@jessegreenberg
Copy link
Contributor Author

The above commits add a supportsTier1Voicing field to initialize-globals and package.json. When present, Voicing is enabled but controls for object and context responses are hidden from the user and those responses are disabled.

I would like to review this with the team to make sure this name is OK. We should decide how to organize this in perennial lists. Related to phetsims/trig-tour#108.

@jessegreenberg
Copy link
Contributor Author

1/22/25 design meeting with @kathy-phet @amanda-phet @terracoda:

Lets make a different perennial list for supportsTier1Voicing.

@jessegreenberg
Copy link
Contributor Author

I discussed the supportsTier1Voicing with the dev team. They mentioned that it is unfortunate that there is supportsTier1Voicing and also supportsVoicing. It would be more simple and clear if there were only one query parameter for each feature.

supportsVoicing should take values that indicate the tier like

    supportsVoicingTier: {
      type: 'string',
      validValues: [ '1', '2' ],
      defaultValue: !!packageSimFeatures.supportsVoicing
    },

Possible validValue is true as well (indicating the full feature set).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant