Skip to content

Commit 62126c6

Browse files
committed
Added isShowingProperty to Dialog, see phetsims/sun#369
1 parent 0f1967c commit 62126c6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

js/AboutDialog.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ define( function( require ) {
249249
* @override
250250
*/
251251
show: function() {
252-
if ( UpdateCheck.areUpdatesChecked && !this.isShowing ) {
252+
if ( UpdateCheck.areUpdatesChecked && !this.isShowingProperty.value ) {
253253
UpdateCheck.resetTimeout();
254254

255255
// Fire off a new update check if we were marked as offline or unchecked before, and we handle updates.
@@ -273,7 +273,7 @@ define( function( require ) {
273273
* @override
274274
*/
275275
hide: function() {
276-
if ( this.isShowing ) {
276+
if ( this.isShowingProperty.value ) {
277277
Dialog.prototype.hide.call( this );
278278

279279
if ( UpdateCheck.areUpdatesChecked ) {

js/UpdateDialog.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ define( function( require ) {
101101
* @public (joist-internal)
102102
*/
103103
show: function() {
104-
if ( UpdateCheck.areUpdatesChecked && !this.isShowing ) {
104+
if ( UpdateCheck.areUpdatesChecked && !this.isShowingProperty.value ) {
105105
UpdateCheck.resetTimeout();
106106

107107
// Fire off a new update check if we were marked as offline or unchecked before, and we handle updates.
@@ -124,7 +124,7 @@ define( function( require ) {
124124
* @public (joist-internal)
125125
*/
126126
hide: function() {
127-
if ( this.isShowing ) {
127+
if ( this.isShowingProperty.value ) {
128128
Dialog.prototype.hide.call( this );
129129

130130
if ( UpdateCheck.areUpdatesChecked ) {

0 commit comments

Comments
 (0)