Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift command doesn't work on Layer Model screen #409

Closed
KatieWoe opened this issue May 15, 2024 · 1 comment
Closed

Shift command doesn't work on Layer Model screen #409

KatieWoe opened this issue May 15, 2024 · 1 comment
Assignees
Labels
type:bug Something isn't working

Comments

@KatieWoe
Copy link
Contributor

Test device
Samsung
Operating System
Win 11
Browser
Chrome
Problem description
For phetsims/qa#1086
When using keyboard nav to move the Flux Meter on the Layer Model screen, using shift + up/down does not move the meter in smaller steps as it should. It moves the same amount as not using shift. The shift command works properly on the Flux Meter on the Photons screen.

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Greenhouse Effect‬
URL: https://phet-dev.colorado.edu/html/greenhouse-effect/1.3.0-rc.1/phet/greenhouse-effect_all_phet.html
Version: 1.3.0-rc.1 2024-05-13 19:29:11 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36
Language: en-US
Window: 1536x695
Pixel Ratio: 1.25/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 31 uniform: 4096
Texture: size: 8192 imageUnits: 32 (vertex: 32, combined: 64)
Max viewport: 8192x8192
OES_texture_float: true
Dependencies JSON: {}

@KatieWoe KatieWoe added the type:bug Something isn't working label May 15, 2024
@arouinfar
Copy link
Contributor

Good catch @KatieWoe, but in this case the difference is intentional.

The step sizes for the flux meter were specified in #367. For the Layer Model Screen, we chose discrete steps for two reasons. First, the flux is constant between the layers so fine adjustment is unnecessary. Second, if the probe collides with a layer, the sim will automatically bump it away. This creates a really confusing experience for screen reader users. To avoid this, we specified an array of possible positions because there wasn't a uniform step size that would avoid all layers.

@jbphet there isn't anything we need to do here, closing.

@arouinfar arouinfar closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants