Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should dynamic locale and description features interact? #299

Open
pixelzoom opened this issue Jun 12, 2023 · 6 comments
Open

How should dynamic locale and description features interact? #299

pixelzoom opened this issue Jun 12, 2023 · 6 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 12, 2023

This issue came out of a discussion that @jbphet and I had in #288.

We need to confirm that the dynamic locale and description features work well together. Because we only have English descriptions, we should verify that when we switch between English and some other locale, the features are "well behaved".

For example, if we switch from English to Spanish, we probably don't want descriptions to continue to be read in English. And if we switch from Spanish to English, do we want descriptions to be read?

Since we're not quite sure what "well behaved" means, let's start there. @arouinfar thoughts? Want to discuss with @jbphet and me?

@jbphet
Copy link
Contributor

jbphet commented Jun 13, 2023

A general issue on the interaction between dynamic locale and description has been logged, see phetsims/scenery#1563.

@arouinfar
Copy link
Contributor

I commented in phetsims/scenery#1563, but the main takeaway for Greenhouse Effect is that the Localization tab should be screen reader accessible. The other tabs of the Preferences dialog already support description.

@arouinfar arouinfar removed their assignment Jun 14, 2023
@pixelzoom
Copy link
Contributor Author

Conclusions are in phetsims/scenery#1563 (comment).

Work required to unblock Greenhouse Effect 1.2 publication is in phetsims/joist#930.

@pixelzoom
Copy link
Contributor Author

Great to see that phetsims/joist#930 has been addressed.

@jessegreenberg can you please summarize here how QA should test this during Greenhouse dev testing?

@pixelzoom
Copy link
Contributor Author

Ping @jessegreenberg -- see #299 (comment)

@jessegreenberg
Copy link
Contributor

I met with @KatieWoe and @Nancy-Salpepi last week to discuss testing Preferences for screen reader accessibility so they are aware. Also, the Localization tab was tested for screen reader access in a recent dev test phetsims/qa#958

@pixelzoom pixelzoom removed their assignment Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants