Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indistinct edges to coils #218

Open
KatieWoe opened this issue Dec 22, 2020 · 4 comments
Open

Indistinct edges to coils #218

KatieWoe opened this issue Dec 22, 2020 · 4 comments

Comments

@KatieWoe
Copy link
Contributor

Test device
Dell
Operating System
Win 10
Browser
Firefox
Problem description
For phetsims/qa#592. Not a major problem. Easiest seen with keyboard nav.
When moving the magnet through/past the coil so that is "scrapes" the top/bottom the edges will make the clink sound as if the magnet is being stopped. If the magnet is moving using the keyboard 1,2,3 commands, it will stop as if it hit the edge of the coil. However, you can still use the arrows to move it past this point.
Steps to reproduce

  1. Use keyboard nav to position the magnet against one of the inside edges of the coil
  2. Use only the left and right arrows to move the magnet back and forth through the coil
  3. Move the magnet outside the coil while keeping it in line
  4. Use 1,2,3 to auto slide the magnet toward the coil
  5. When it stops from hitting the edge of the coil, press the left/right arrow key to move it inside the coil

Visuals

slideWhileBumpingCoil.MOV
slideIntoCoil.MOV

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Faraday's Law‬
URL: https://phet-dev.colorado.edu/html/faradays-law/1.4.0-rc.4/phet/faradays-law_all_phet.html
Version: 1.4.0-rc.4 2020-12-22 18:41:37 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0
Language: en-US
Window: 1280x687
Pixel Ratio: 1.5/1
WebGL: WebGL 1.0
GLSL: WebGL GLSL ES 1.0
Vendor: Mozilla (Mozilla)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@jbphet
Copy link
Contributor

jbphet commented Dec 23, 2020

This is definitely not significant enough to be considered blocking for the 1.4 release, but I will take a look at some point.

@KatieWoe
Copy link
Contributor Author

I wanted to see if this was in the published version. However, since the published version doesn't have sound or keyboard nav there isn't really a way to tell.

@jbphet
Copy link
Contributor

jbphet commented Mar 4, 2021

The fact that the sound is emitted when dragging back and forth right near the coil doesn't bother me at all, and in fact it seems pretty natural. It's kind of like the magnet makes a "glancing blow". I was bothered by the fact that the behavior was inconsistent between dragging the magnet with the arrow keys and moving it using the speed keys, so I've changed it to use the same code for determining whether a motion should be blocked. The speed keys now behave more like the arrow keys.

@KatieWoe - please test this and, if it seems reasonable, mark it as unassigned and it will go out with the next release from master. It doesn't seem worth a maintenance release, since it is a rare and not-very-problematic use case.

@jbphet jbphet assigned KatieWoe and unassigned jbphet Mar 4, 2021
@KatieWoe
Copy link
Contributor Author

KatieWoe commented Mar 4, 2021

Looks good on master.

@KatieWoe KatieWoe removed their assignment Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants