Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation (and probably behavior) in MagnetRegionManager #164

Open
jbphet opened this issue Jul 28, 2020 · 1 comment
Open
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jul 28, 2020

I came across with while working on #162. In MagnetRegionManager.getTouchingCoil, the documentation doesn't match what the function does, and what it does relies on the order in which restricted bounds are placed into what was a private variable, which seems fragile. I'll mark the area in the code with a TODO.

This appears to be related to description, and I'm not sure who is working on that for Faraday's Law, so I'll assign to @emily-phet so that she can get it to the right person.

@jbphet
Copy link
Contributor Author

jbphet commented Jul 28, 2020

@emily-phet says that @jessegreenberg is going to be working on description, so I'm passing this on to him.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants