From 3e56473e59a5bdbfbf77621b487ab8356013096f Mon Sep 17 00:00:00 2001 From: pixelzoom <cmalley@pixelzoom.com> Date: Thu, 14 Sep 2023 16:24:57 -0600 Subject: [PATCH] TODO https://github.com/phetsims/faradays-law/issues/164, https://github.com/phetsims/tasks/issues/1129 --- js/faradays-law/view/MagnetRegionManager.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/js/faradays-law/view/MagnetRegionManager.js b/js/faradays-law/view/MagnetRegionManager.js index 6fe6310..d1b0ccf 100644 --- a/js/faradays-law/view/MagnetRegionManager.js +++ b/js/faradays-law/view/MagnetRegionManager.js @@ -143,10 +143,9 @@ class MagnetRegionManager { const listOfRestrictedBounds = this.model.bottomCoilRestrictedBounds.concat( this.model.topCoilRestrictedBounds ); const i = listOfRestrictedBounds.indexOf( intersectedBounds ); - // TODO: The code below looks wrong. The return type doesn't match the header docs, and the whole thing is too https://github.com/phetsims/tasks/issues/1129 - // tightly coupled to the way bounds are managed in the model. See - // https://github.com/phetsims/faradays-law/issues/164. Also, it seems like it should return null instead of -1 if - // no intersection is found. + //TODO https://github.com/phetsims/faradays-law/issues/164 The code below looks wrong. The return type doesn't + // match the header docs, and the whole thing is too tightly coupled to the way bounds are managed in the model. + // Also, it seems like it should return null instead of -1 if no intersection is found. if ( i >= 0 ) { return coilSides[ i ];