Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address TODOs #95

Closed
pixelzoom opened this issue Apr 28, 2019 · 3 comments
Closed

address TODOs #95

pixelzoom opened this issue Apr 28, 2019 · 3 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 28, 2019

Several TODOs and dead code in Quaternion.js with no associated GitHub issue:

6 * TODO: convert from JME-style parametrization into classical mathematical description?
96    // TODO: note why this is the case? product noted everywhere is the other one mentioned!
      // mathematica-style
//        return new Quaternion(
//                this.x * quat.x - this.y * quat.y - this.z * quat.z - this.w * quat.w,
//                this.x * quat.y + this.y * quat.x + this.z * quat.w - this.w * quat.z,
//                this.x * quat.z - this.y * quat.w + this.z * quat.x + this.w * quat.y,
//                this.x * quat.w + this.y * quat.z - this.z * quat.y + this.w * quat.x
//        );
138      // TODO: optimization?
pixelzoom added a commit that referenced this issue Apr 28, 2019
@pixelzoom pixelzoom changed the title convert from JME-style parametrization into classical mathematical description? address TODOs Apr 28, 2019
@pixelzoom
Copy link
Contributor Author

This is apparently a pervasive problem in dot. Moving to #96.

@phet-dev
Copy link
Contributor

Reopening because there is a TODO marked for this issue.

@phet-dev phet-dev reopened this Sep 13, 2023
@marlitas
Copy link
Contributor

This never got closed. Ironically, because of a TODO issue. I committed a fix that I accidentally linked to #96. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants