-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to Vector3 for ES6 modules #101
Comments
Looks like there are other uses of the 166 return Math.acos( dot.clamp( this.normalized().dot( v.normalized() ), -1, 1 ) );
492 return new dot.Vector2( this.x, this.y );
502 return new dot.Vector4( this.x, this.y, this.z, 1 );
781 return this.setXYZ( dot.Utils.roundSymmetric( this.x ),
782 dot.Utils.roundSymmetric( this.y ),
783 dot.Utils.roundSymmetric( this.z ) ); |
All the imports seemed used to me, I removed the NOTE that is now covered by the explanation of the ts-expect-error. Also there is still a need for the Quaternion workaround as far as I could see. Anything else @jonathanolson? |
The workaround isn't needed, it would just mean we'd have to use Cleaned up a few other things above. Look good @zepumph ? |
Yes, looks nice, I also made #118 for when the time is right. Ready to close? |
Looks good to close, since we have the separate issue for circularity. Thanks! |
Noted while using Vector3 in Natural Selection, and working on #100.
In Vector3:
Now that's we're using ES6 modules:
dot.Quaternion
be replaced with an import?The text was updated successfully, but these errors were encountered: