Panel doesn't resize when hiding currentTypeRadioButtonGroup

[arouinfar]

For phetsims/qa#1224

I found a dynamic layout bug in CCK: DC dev.2, as well as the latest published version 1.3. This bug is also present in the CCK: AC flavors on main.

Setting view.displayOptionsPanel.currentTypeRadioButtonGroup.visibleProperty to false leaves a gap in the panel.

[samreid]

Related to #945

[samreid]

@zepumph and I pushed a proposed fix in the commit. @arouinfar can you please test on phettest? We saw that hiding both buttons individually is not well supported, but we considered this out of scope. Close if all is well.

[arouinfar]

Thanks @samreid @zepumph. Looks good on main.

We saw that hiding both buttons individually is not well supported, but we considered this out of scope.

Agreed!

Close if all is well.

Shouldn't this be verified in the RC test instead of closed?

[zepumph]

Shouldn't this be verified in the RC test instead of closed?

We are still in dev-test land. I'll make an RC from main within the next day or two.

[arouinfar]

We are still in dev-test land. I'll make an RC from main within the next day or two.

Right. I meant that this issue should be in the list of things to verify in the upcoming RC test, so it's premature to close it. Typically, we don't close issues discovered in dev tests until QA verifies the fix in the RC test.