-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard commands don't work in iframes #1027
Comments
@samreid @jonathanolson and I discussed this issue, and we feel like the best course of action is having support for a focusable element inside a sim when there are no other focusable elements (no PDOM or interactive description). This solution attempts to apply a general solution, but in a way where we only turn it on in CCK right now. Basically there should be a focusable content in sims without keyboard interaction. Maybe it can say something like "this is an interactive sim...". It doesn't matter too much at this time, but it could be useful in other cases too (so tabbing a webpage doesn't just skip the sim, treating it like a black box).
|
Ok. I got to a commit point here. I created a CCKCSim to house this new CCK-specific code, and a general function in SimDisplay. @samreid can you please review? |
Device
Lenovo Laptop
OS
Win 11
Browser
Chrome
Problem Description
For phetsims/qa#1224. Discovered and discussed in phetsims/circuit-construction-kit-dc#209
When the sim is in an iframe the delete/backspace button to delete an element doesn't work. @Nancy-Salpepi noted that alt+r to reset all also doesn't work in this case.
The text was updated successfully, but these errors were encountered: