-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert phetioCompareAPIs to Typescript #1526
Comments
Converted and fixed in the above. The webpack build was ignoring files from |
@samreid can you please give a spotcheck. Mostly for the typescript in chipper/js/phet-io/ |
I read the recent commits and everything seems reasonable. I tested by renaming a tandem and running |
Reopening because there is a TODO marked for this issue. |
I can address these TODO's, I forgot to search them during the code review. Leaving self-assigned. |
I'm uncertain what to do about |
@zepumph and I reviewed this issue, and we feel this is high priority to discriminate between browser-and-node code and make sure it is correctly typed via a tsconfig.json file. We need |
Alright. All TODOs have been handled, and we will pick things up in phetsims/perennial#418 |
https://github.com/phetsims/phet-io/issues/1951
phetsims/perennial#410
phetsims/perennial#403
#1465
This typescript module can then be used in sim AND build-tools code.
The text was updated successfully, but these errors were encountered: