Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert phetioCompareAPIs to Typescript #1526

Closed
zepumph opened this issue Nov 18, 2024 · 10 comments
Closed

Convert phetioCompareAPIs to Typescript #1526

zepumph opened this issue Nov 18, 2024 · 10 comments

Comments

@zepumph
Copy link
Member

zepumph commented Nov 18, 2024

https://github.com/phetsims/phet-io/issues/1951
phetsims/perennial#410
phetsims/perennial#403
#1465

This typescript module can then be used in sim AND build-tools code.

@zepumph zepumph self-assigned this Nov 18, 2024
zepumph added a commit that referenced this issue Nov 18, 2024
zepumph added a commit to phetsims/function-builder that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/gas-properties that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/fractions-intro that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/function-builder-basics that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/number-line-distance that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/fractions-equality that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/number-line-operations that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/number-compare that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/gene-expression-essentials that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/fractions-mixed-numbers that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/calculus-grapher that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/bending-light that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/area-model-algebra that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/acid-base-solutions that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/area-model-introduction that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/area-model-common that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/area-model-multiplication that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/balancing-act that referenced this issue Nov 20, 2024
zepumph added a commit to phetsims/atomic-interactions that referenced this issue Nov 20, 2024
@zepumph
Copy link
Member Author

zepumph commented Nov 21, 2024

Converted and fixed in the above. The webpack build was ignoring files from /phet-io/ in phet brand build (what phet-io-wrappers standalone was build in).

@zepumph
Copy link
Member Author

zepumph commented Nov 21, 2024

@samreid can you please give a spotcheck. Mostly for the typescript in chipper/js/phet-io/

@samreid
Copy link
Member

samreid commented Nov 23, 2024

I read the recent commits and everything seems reasonable. I tested by renaming a tandem and running grunt pre-commit --phet-io-api and it correctly caught the change. Closing.

@samreid samreid closed this as completed Nov 23, 2024
@phet-dev phet-dev reopened this Nov 24, 2024
@phet-dev
Copy link
Contributor

Reopening because there is a TODO marked for this issue.

@samreid
Copy link
Member

samreid commented Nov 24, 2024

I can address these TODO's, I forgot to search them during the code review. Leaving self-assigned.

@samreid
Copy link
Member

samreid commented Nov 25, 2024

I'm uncertain what to do about getStringMap TODO, and the other 3 todos are unclear whether they were meant to be a question for the review. @zepumph can you please advise?

@samreid samreid assigned zepumph and unassigned samreid Nov 25, 2024
@samreid
Copy link
Member

samreid commented Nov 26, 2024

@zepumph and I reviewed this issue, and we feel this is high priority to discriminate between browser-and-node code and make sure it is correctly typed via a tsconfig.json file. We need browser-and-node/ in perennial-alias and chipper. For instance, these files should not know what process.exit() is. While this remains a high priority, it does not need to block publication for new RCs.

@zepumph
Copy link
Member Author

zepumph commented Nov 26, 2024

Alright. All TODOs have been handled, and we will pick things up in phetsims/perennial#418

@zepumph zepumph closed this as completed Nov 26, 2024
jessegreenberg pushed a commit to phetsims/perennial that referenced this issue Dec 10, 2024
jessegreenberg pushed a commit to phetsims/perennial that referenced this issue Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants