Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance optimization for ElectricPotentialLine #173

Open
samreid opened this issue Oct 22, 2019 · 0 comments
Open

Performance optimization for ElectricPotentialLine #173

samreid opened this issue Oct 22, 2019 · 0 comments
Labels
type:performance

Comments

@samreid
Copy link
Member

samreid commented Oct 22, 2019

From #171 @jonathanolson said:

Avoiding trigonometry for the perpendicular computation might help performance (e.g. -y, x in this case).

I replied:

There are 5 occurrences of normalize().rotate( Math.PI / 2 ), I'm also seeing many other opportunities for performance improvements by eliminating allocations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samreid