Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen Screenshots #335

Closed
veillette opened this issue Apr 13, 2023 · 5 comments
Closed

Screen Screenshots #335

veillette opened this issue Apr 13, 2023 · 5 comments
Assignees

Comments

@veillette
Copy link
Contributor

In #1

There is an item for

We already have the main and alternate screenshots in #321, but we need screen screenshots.

We'll need screenshots before we can publish 1.0.0. The screen screenshots will need to be committed to master, then cherry-picked to calculus-grapher 1.0 branch.

According to https://github.com/phetsims/website/issues/1322

I think that screenshots should go in the assets folder in github (like https://github.com/phetsims/friction/tree/master/assets), and name them {{sim-name}}-screenshot-screen{{screen index number}}.png. It would be preferable not to save them in google drive first, but to go ahead and save them in github directly.

For example Acid Base Solutions, where the screens are "Introduction" and "My Solution", should have the following files:

assets/acid-base-solutions-screenshot-screen1.png (Introduction)
assets/acid-base-solutions-screenshot-screen2.png (My Solution)

@veillette
Copy link
Contributor Author

Number-play is in the same boat and after consultation with @arouinfar, it turns out not to be blocking for publication.
However, the screen screenshots should still be committed to master.

@amanda-phet
Copy link
Contributor

This is done. @veillette do you need this open? Please feel free to close.

@amanda-phet amanda-phet assigned veillette and unassigned amanda-phet Apr 17, 2023
@veillette
Copy link
Contributor Author

veillette commented Apr 17, 2023

Thanks @amanda-phet ! yes leave the issue opened as we need to cherry pick the screen screenshots for the 1.0 branch,

veillette pushed a commit that referenced this issue Apr 17, 2023
#335
(cherry picked from commit 9698d92)
@veillette
Copy link
Contributor Author

The files have been cherry picked in 1.0 branch.

@veillette
Copy link
Contributor Author

The screen screenshots have been added to the master and 1.0 branch. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants