-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix startup performance #7
Comments
Big delays are in fromSerial2 (CompleteMolecule and the supertype MoleculeStructure), a bit from PubChemAtom reader |
It has been noted that start up time isn't an issue and performance issues haven't been reported in the latest dev-test. See here: #109. |
As of today (2020-01-23), I would say the startup time is a bit long. Testing BAM on master gave the following results. (These times were measured from hitting the reload page button to the time the home screen was loaded.)
@Denz1994, if these times are acceptable, feel free to close. Also, the loading bar is empty for a decent chunk of the loading time, which might make a user think the sim is having trouble loading. I can also do more testing if necessary. |
@Denz1994, I just tested https://phet-dev.colorado.edu/html/build-a-molecule/0.0.0-dev.47/phet/build-a-molecule_en_phet.html and the performance was much faster on all the above platforms. Load time took ~5 seconds on all platforms, and this seems acceptable. |
Thanks for double-checking on the start up time. Closing this one. |
It's very slow, sometimes ~20 seconds on the iPad. This can consist of:
The text was updated successfully, but these errors were encountered: