Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom magnification support #208

Open
Denz1994 opened this issue Aug 27, 2020 · 2 comments
Open

Zoom magnification support #208

Denz1994 opened this issue Aug 27, 2020 · 2 comments

Comments

@Denz1994
Copy link
Contributor

I was testing the zoom magnification feature using the ?supportZoom=true in BAM. The latest BAM RC doesn't work with this query parameter. More specifically, pinch to zoom and Cmd + doesn't work on my MacBook.

Here is the link that was tested.

@ariel-phet mentioned that this shouldn't block 1.0 and most likely will get included in this sim's next maintenance release. Assigning to @jessegreenberg to take an initial look with any assistance I can provide.

@jessegreenberg
Copy link
Contributor

Regarding the query parameter, it looks like SHAs for build-a-molecule were taken while the param was still called zoom (instead of supportsZoom). When zoom is used, there is some magnification but it isn't working very well.

I checked out the scenery SHA for 1.0.0-rc.2, and it is from June 19, 2020. The published molecules-and-light scenery SHA with magnification is from July 21. So it looks like code related to zoom at this release was taken at a transient or not-working state.

Figuring out how to fix the old code could be done, but the scenery SHA for this release is > 2 months old now, and there have been many changes since then related to the zoom feature. It would be much easier (at least for zoom) to include in a republication off of master.

shouldn't block 1.0 and most likely will get included in this sim's next maintenance release.

@Denz1994 will this release be a maintenance release patched into 1.0 or a minor release off of master?

@Denz1994
Copy link
Contributor Author

Denz1994 commented Sep 5, 2020

This will most likely be captured in a minor release off of master. We can capture this feature when that time comes.

@Denz1994 Denz1994 removed their assignment Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants