Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer area review #177

Closed
jonathanolson opened this issue May 7, 2020 · 3 comments
Closed

Pointer area review #177

jonathanolson opened this issue May 7, 2020 · 3 comments

Comments

@jonathanolson
Copy link
Contributor

As noted in the code review doc (#173), there should be a review of pointer areas done and signed off.

@Denz1994
Copy link
Contributor

Note: Pointer areas are shown for buckets that aren't yet visible but exist in the carousel's preceding and succeeding pages.

Assigning to @arouinfar to sign off on pointer areas.

@arouinfar
Copy link
Contributor

The pointerAreas look sufficiently dilated to me, but I don't have a touch device to test it on. @Denz1994 if this sim has already been tested on an iPad, I think it's safe to assume the touch areas are fine as-is.

@arouinfar arouinfar assigned Denz1994 and unassigned arouinfar May 12, 2020
@Denz1994
Copy link
Contributor

This sim has been tested on an iPad and the only issues that came up regarding touch areas were #116. This issue is safe to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants