Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Chrome OS, buckets too large, spill over into next page of carousel #132

Closed
ghost opened this issue Dec 5, 2019 · 8 comments
Closed
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Dec 5, 2019

Test Device

Lovelace

Operating System

Chrome OS 79.0.3945.42

Browser

Chrome

Problem Description

For phetsims/qa#459.

Visuals

1
2
3

@Denz1994
Copy link
Contributor

Denz1994 commented Jan 9, 2020

From #134 (comment)

This was caused by the bounds of buckets being leaked over into other pages in the carousel. Adjusting the bounds of the kitPanel and the bucket widths makes it so a user can drag these leaked atoms into another kit's playAreaNode.

This also makes it so they buckets don't visually leak into the next carousel page.

@Denz1994
Copy link
Contributor

Can @KatieWoe verify this isn't an issue anymore in this dev version?

@KatieWoe
Copy link
Contributor

There is a very, very minor overlap of the buckets in the third page of the carousel on the third screen. So the second and forth pages have slight dots on the edge. Seen on Win 10 Chrome. Super nitpicky.
here2
here4

Denz1994 added a commit that referenced this issue Jan 15, 2020
@Denz1994
Copy link
Contributor

Very good eye @KatieWoe. This is literally a pixel polish. Should be fixed in this dev

@KatieWoe
Copy link
Contributor

This issue looks good on that dev version

@KatieWoe KatieWoe removed their assignment Jan 16, 2020
@KatieWoe
Copy link
Contributor

I'll also look at a few other platforms just in case today.

@KatieWoe KatieWoe self-assigned this Jan 16, 2020
@KatieWoe
Copy link
Contributor

All looks good

@KatieWoe KatieWoe removed their assignment Jan 16, 2020
@Denz1994
Copy link
Contributor

Thanks for checking. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants