Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated interaction with 3D button causes reload #110

Closed
loganbraywork opened this issue Nov 21, 2019 · 3 comments
Closed

Repeated interaction with 3D button causes reload #110

loganbraywork opened this issue Nov 21, 2019 · 3 comments
Assignees
Labels

Comments

@loganbraywork
Copy link

Test device
Windows 7 laptop
Operating System
Windows 7
Browser
Chrome
Problem description
For phetsims/qa#459

When the 3D button is pressed multiple times in rapid succession, the sim will eventually face an error and need to reload.
Steps to reproduce

  1. Create any molecule (O2 is quickest)
  2. Repeatedly and Rapidly click the 3D button
    Visuals
    2019-11-21ThreeDBttnBldMlce

Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: ‪Build a Molecule‬
URL: https://phet-dev.colorado.edu/html/build-a-molecule/0.0.0-dev.23/phet/build-a-molecule_all_phet.html
Version: 0.0.0-dev.23 2019-11-20 23:29:39 UTC
Features missing: touch
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36
Language: en-US
Window: 1366x625
Pixel Ratio: 1/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 32 varying: 32 uniform: 256
Texture: size: 8192 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 8192x8192
OES_texture_float: true
Dependencies JSON: {}

Denz1994 added a commit that referenced this issue Dec 5, 2019
2.) Ball and Stick Model bond matrix corrected.
#111
@Denz1994
Copy link
Contributor

Denz1994 commented Dec 5, 2019

This failure was being triggered due to the browser refreshing when too many ThreeNodes are created (see here for more info). Reserving a single dialog node in the BAMView restricts the sim to build only one ThreeNode.

The above commit should have solved this.

@Denz1994
Copy link
Contributor

Denz1994 commented Dec 6, 2019

Can you confirm this isn't happening in this dev version @KatieWoe?

@KatieWoe
Copy link
Contributor

KatieWoe commented Dec 6, 2019

Looks good in the dev version

@KatieWoe KatieWoe removed their assignment Dec 6, 2019
@Denz1994 Denz1994 closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants