Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sounds for intractable elements #108

Open
Denz1994 opened this issue Nov 20, 2019 · 1 comment
Open

Sounds for intractable elements #108

Denz1994 opened this issue Nov 20, 2019 · 1 comment

Comments

@Denz1994
Copy link
Contributor

A recent change to common code components in phetsims/tambo#73 caused several buttons to have sounds played when pressed. This made me question whether we should integrate more sounds for other elements.

These elements would include:

  • Scissors ( a snip? tear? or base pushButtonSound)
  • SliceNode (see Slice sound effect #40 (comment))
  • Returning atoms to buckets (maybe a single thump to give to make them feel tangible)

Thoughts @ariel-phet?

@ariel-phet
Copy link

@Denz1994 a proper sound design will need to take place for those other signs, probably not appropriate for 1.0, as that design process can be longer.

As for the other sounds in the sim (besides perhaps the reset all button, and the "ding" that is in the sim already associated with a correct collection), other sounds should be disabled. I believe tambo is setup for these other sounds to be off by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants