Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move a11y strings into main strings json #463

Open
zepumph opened this issue Mar 22, 2020 · 3 comments
Open

move a11y strings into main strings json #463

zepumph opened this issue Mar 22, 2020 · 3 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Mar 22, 2020

From phetsims/chipper#795. I think that @jessegreenberg should do this, because likely there should be some organizational refactoring done in this repo, in part because there are so many strings here.

@jbphet
Copy link
Contributor

jbphet commented Aug 31, 2021

This issue was reviewed during today's sound design meeting, and it looks like the a11y strings are still separate from the other strings (they are in BASEA11yStrings.js). This doesn't seem like a blocking issue for the upcoming publication of version 1.5.0, but we thought it best to check. @jessegreenberg - Should we try to get this done now, or leave it for the next publication from master?

@zepumph
Copy link
Member Author

zepumph commented Aug 31, 2021

I'll put in a strong preference to doing this sooner rather than later, and not keeping this technical debt lingering.

@jessegreenberg
Copy link
Contributor

Agreed this should be done! But this also doesn't need to block taking RC SHAs. I won't be able to get to this until 9/7/21 at the earliest, @jbphet if you would like to take RC SHAs before then I think that is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants