Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Emitter emit1, emit2, emit3 #218

Closed
pixelzoom opened this issue Feb 9, 2019 · 2 comments
Closed

remove Emitter emit1, emit2, emit3 #218

pixelzoom opened this issue Feb 9, 2019 · 2 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 9, 2019

In light of work like phetsims/scenery#928 and #211 ...

Emitter emit1, emit2, and emit3 should be deleted. They are all deprecated. @samreid recently changed their implementations to be nearly identical and call emit, see 880b311. And they would be relatively easy to replace with emit using global string replacement.

Occurrences:
70 emit1
9 emit2
6 emit3

Assigning to @ariel-phet to prioritize and assign.

@samreid
Copy link
Member

samreid commented Feb 10, 2019

The reason I didn't just tackle this as part of #211 was that emit requires validators whereas emit1,2,3 ignore validation. So we have these kind of options:

a) add a (temporary?) feature to Emitter that ignores validation
b) use validators like [Any] for emit1, [Any,Any] for emit2 etc.
c) add the correct validators for each Emitter as part of this port.

(c) is the preferable long term solution, but it would be nice to shape up the Emitter validator API first, as decided in #204 (comment)

Also self assigning this for further consideration, or in case I figure a simple way to address these 80+ cases.

@samreid samreid self-assigned this Feb 10, 2019
@zepumph
Copy link
Member

zepumph commented Feb 27, 2019

duplicate of #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants