-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emitter .apply() calls should use null instead of this #216
Comments
I fixed the main problem with this, but there are still several other occurrences that will need attention. |
I fixed the validation case. The other site that is implicitly using |
These changes look good. I also agree that it doesn't make sense to change deprecated methods from something like:
to
Hopefully we can update usages soon. |
Discovered in phetsims/scenery#928, For unknown reasons
Emitter
is passingthis
for theapply
calls. I discovered this led to a problem in SimpleDragHandler which was incorrectly usingthis
instead ofself
.The text was updated successfully, but these errors were encountered: