Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we eliminate Validator.pickOptions? #206

Closed
samreid opened this issue Jan 7, 2019 · 1 comment
Closed

Can we eliminate Validator.pickOptions? #206

samreid opened this issue Jan 7, 2019 · 1 comment
Assignees
@samreid @zepumph

Comments

@samreid
Copy link
Member

samreid commented Jan 7, 2019

See #189. There was discussion about whether we need the complexity of pickOptions or not. I think I originally created it to prevent memory leaking, but I'm not 100% sure it's necessary.
@zepumph
Copy link
Member

zepumph commented Jan 18, 2019

This was eliminated in 2f48b0e

@zepumph zepumph closed this as completed Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

@zepumph zepumph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph