Should we separate Validator.options.valueType into valueTypeOf + valueInstanceOf?

[samreid]

From Validator.js:

// TODO: now that we have Validator, do we still want to overload valueType?  Or split it up into:
// TODO: {valueTypeOf: 'boolean'} vs {valueInstanceOf: 'Vector2'}
if ( options.valueType ) {
  const valueType = options.valueType;
  if ( typeof valueType === 'string' ) { // primitive type
    assert( typeof value === valueType, 'value should have typeof ' + valueType + ', value=' + value );
  }
  else if ( typeof valueType === 'function' ) { // constructor
    assert( value instanceof valueType, 'value should be instanceof ' + valueType.name + ', value=' + value );
  }
}

Related to #189.

Client code would change from:

new Property(1,{valueType: 'number'});
new Property(myVector,{valueType: Vector2});

to

new Property(1,{valueTypeOf: 'number'});
new Property(myVector,{valueInstanceOf: Vector2});

Self assigning to consider before bringing it to the dev team.

[samreid]

While it would be possible to simplify the implementation, having a simple and nice API is more important. The TODOs have been removed. Closing.