Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arithmetic] missing keyboard input #7

Closed
MDmitrieva opened this issue Jun 11, 2014 · 24 comments
Closed

[Arithmetic] missing keyboard input #7

MDmitrieva opened this issue Jun 11, 2014 · 24 comments

Comments

@MDmitrieva
Copy link

that if the user is using a mouse and keyboard, the sim should allow number entry with the keyboard so that they don’t have to use the mouse if they don’t want.

@jbphet
Copy link
Contributor

jbphet commented Jun 13, 2014

PhET has considered the requirement of letting the user enter values from an external keyboard, and we've decided that it is too complex to implement at this time. It is no longer required, and the requirement that @MDmitrieva quoted above has been removed from the original spec. The users should only be able to enter values from the on-screen keypad.

Closing.

@jbphet jbphet closed this as completed Jun 13, 2014
@oliver-phet
Copy link

Another user reported to phethelp:

on the new arithmetic simulation (both online and on the download), I am unable to type in the answer to the problems. I can only use the on-screen number box. I had no such problem with the legacy version. Is there any way to fix this?

@oliver-phet
Copy link

Another request for this feature received 12/11:

The app is working well. The only trouble is we would like to use the physical keyboard like in the older version.

@amanda-phet
Copy link
Contributor

amanda-phet commented Dec 11, 2017

If it is an iPad app would the keyboard pop up and cover the sim? Or would it be limited to external keyboards that are attached/plugged in?

When we get to keyboard navigation for this sim, I wonder if it would make keyboard entry possible. because right now we don't have a design for keypad entry so it seems like that would be the time to tackle it. Tagging @jessegreenberg @terracoda and @emily-phet to consider this when we get to this sim.

@jbphet
Copy link
Contributor

jbphet commented Dec 12, 2017

Since there is a keypad within the sim, having one pop up on iPad seems undesirable. Hopefully it is possible to support key entry on desktop and not trigger the appearance of the keypad in iOS, but this will need to be investigated as part of the effort.

@jbphet
Copy link
Contributor

jbphet commented Dec 12, 2017

Reopening, since the issue is being reconsidered.

@jbphet jbphet reopened this Dec 12, 2017
@jessegreenberg
Copy link
Contributor

If it is an iPad app would the keyboard pop up and cover the sim?

By default, yes I expect it will cover the sim. Number entry is possible but not something we have worked on yet. Making sure that an on screen keyboard does not appear for mobile devices will be part of this investigation.

@emily-phet
Copy link

Is this sim being actively worked on? If not, and no sims with a keyboard are being worked on, let's wait until one comes up to dig into this. Otherwise, it would be worth taking a little time to see if we can stop the triggering of the onscreen keyboard on mobile devices, and then discuss next steps once we have that info. @jbphet @jessegreenberg

@jessegreenberg
Copy link
Contributor

At this time, the a11y team is not working on any other sims with a number input that require keyboard input like this.

I also do not think this sim is being actively worked on, but @jbphet please correct me if I am wrong.

@jessegreenberg
Copy link
Contributor

I noticed that the cursor in this sim blinks whether or not the number readout has keyboard focus, which makes it look like it always has focus. That could be something to talk about when we return to this sim for a11y.

@jbphet
Copy link
Contributor

jbphet commented Jan 8, 2018

@jessegreenberg - you are correct, there is no active development on the main functionality of this simulation. I'll set the priority to deferred and unassign for now.

@marlitas
Copy link
Contributor

This issue does not seem like it would be within the scope of the upcoming Arithmetic region and culture publication, so I will leave as deferred. @amanda-phet let me know if you think otherwise.

@amanda-phet
Copy link
Contributor

Have any sims with numberPad (I think that's the name) been developed yet with alt input? It seems like that is the time to tackle how to better design the experience with the numberPad.

@oliver-phet
Copy link

Have any sims with numberPad (I think that's the name) been developed yet with alt input? It seems like that is the time to tackle how to better design the experience with the numberPad.

My Solar System
phetsims/my-solar-system#86
phetsims/scenery-phet#790

I know there have been various issues around keyboard input and I've commented on a few in the past... I really dislike the current input experience and would have a strong preference for moving toward default OS keyboard support!

@marlitas
Copy link
Contributor

marlitas commented Dec 8, 2023

I think this is somewhat covered by the work needing to be done here: phetsims/scenery-phet#283

It was added as a dev priority, but I'm not sure that will get finalized in time for Arithmetic...

@amanda-phet
Copy link
Contributor

amanda-phet commented Dec 15, 2023

@marlitas is going to check in with @jessegreenberg to see if this seems worth approaching and if so, we can set up a meeting to discuss!

@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 15, 2023

In our design discussion today, we also noted that arithmetic is using NumberKeypad, which is deprecated. It's the last sim to be using it, so it would be really great to convert to Keypad (the new solutions) so that we can delete NumberKeypad.

Tracking in #200.

@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 15, 2023

Also noted during today's design discussion. The blinking cursor is probably something that was ported from Flash by MLL (search for "blinking of cursor" in EquationNode.js). If you can't use the keyboard to type numbers in the HTML5 version, then that cursor is totally misleading -- I (for example) had to be told by @amanda-phet to use the keypad. So if it turns out that typing numbers is not possible, I recommend deleting the blinking cursor, and instead highlighting the '?' in some way (outilne or background fill) to emphasize it.

@marlitas
Copy link
Contributor

@jessegreenberg and I met about this today, and we believe that there is a straightforward solution that allows Arithmetic to use Keypad and keyboard entry without enabling alternative input. We also discussed that the blinking cursor seems helpful in those cases.

@marlitas
Copy link
Contributor

Arithmetic now has keyboard input with the above commits. @jessegreenberg do you mind reviewing for the changes in scenery and scenery-phet?

@marlitas marlitas assigned jessegreenberg and unassigned marlitas Jan 18, 2024
@marlitas
Copy link
Contributor

@KatieWoe or @Nancy-Salpepi, @jbphet brought up a question about how this might work with iPad.

I don't have one to test on. Would either of you be able to check and see if this now triggers the keyboard on iPad in a way that obscures the sim?

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Jan 18, 2024

These changes look good to me, thanks for adding them! I tested in arithmetic.

bout how this might work with iPad.

It won't (unless there is an external BLE keyboard), KeyboardListener just listens for keydown/keyup events. The on-screen keyboard should only pop up for more native text/number inputs like @oliver-phet suggested in #7 (comment). Id love to add that to scenery someday.

@Nancy-Salpepi
Copy link

I just checked the iPad and as Jesse indicated in #7 (comment), the keyboard doesn't popup at all.

@Nancy-Salpepi Nancy-Salpepi removed their assignment Jan 18, 2024
@marlitas
Copy link
Contributor

marlitas commented Feb 9, 2024

I believe this can be closed now. Thanks everyone for their help here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests