Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT: Speed up phet-io build tests by omitting copySupplementalPhetioFiles logic #99

Open
zepumph opened this issue May 29, 2020 · 1 comment

Comments

@zepumph
Copy link
Member

zepumph commented May 29, 2020

This issue is a superset of the linked checkbox in https://github.com/phetsims/phet-io/issues/1664. Part of this process is to generate the phetio api, which kicks off puppeteer and can take upwards of 5 seconds per build. If we don't need this logic for a test, then CT could benefit from this speed increase.

insert large numbers about how often builds occur on CT here

@zepumph zepumph self-assigned this May 29, 2020
@pixelzoom
Copy link
Contributor

pixelzoom commented Nov 11, 2020

For anyone else reading this, "copySupplementalPhetioFiles logic" is apparently copySupplementalPhetioFiles.js, which is used in buildRunnable.js.

@zepumph zepumph removed their assignment Mar 3, 2023
@zepumph zepumph changed the title Speed up phet-io build tests by omitting copySupplementalPhetioFiles logic CT: Speed up phet-io build tests by omitting copySupplementalPhetioFiles logic Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants