-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tool to facilitate comparative testing #87
Comments
This patch allowed me to pixel compare two live simulations interactively: There are some disadvantages, and I didn't commit.
Could we make it asynchronous, and just rely on the user pausing the simulation to compare? Not sure how useful this would be. |
It would be great to be able to run this on production versions and non-phet-io versions. I'll move this to aqua. UPDATE: phet-io-wrappers is private and hence cannot move issues to a public repo. I copied things manually. |
This is working well, I compared master of gravity and orbits to the published version. I'd like to run this past @jonathanolson to see if he has ideas or recommendations, then it would be nice to share with the dev team. |
Questions to discuss with @jonathanolson:
|
Notes from discussion with @jonathanolson.
function sendStep( dt ) {
iframe.contentWindow.phet.joist.sim.stepSimulation( dt );
}
|
I shared this with the team at status meeting a few weeks ago, so the team is roughly aware of it. I don't plan to work on it at the moment, but will add improvements as necessary as I used it in the future. |
From https://github.com/phetsims/phet-io-wrappers/issues/337
Inspired by phetsims/gravity-and-orbits#308, we would like to be able to test when a pure refactor has the same behavior as the previous version. Scenery has a similar feature, but if I recall correctly, it stores to disk and is non-interactive.
This version will run two versions from separate checkouts, and allow interactive or fuzzing.
The text was updated successfully, but these errors were encountered: