-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node unit tests to CT #223
Comments
I believe the best way to do this is to support a new locale test type called |
I believe this is going to work well. Here is an example of the tests I would add (and did locally):
@jonathanolson, can you give this a spot check and let me know what you think. Are we worried about opening things up to all npm run commands? I personally am really excited about being able to add more testing for node code. Let me know |
@jonathanolson and I discussed and we like the idea of locking the The repos we will start with allowing this for:
Adding this directly into the server file seems great. |
Alright. I made the update to restrict repos and restarted CT on sparky. I also added tests. I'll check back in the morning. |
This is working great after the above bug fix! |
From phetsims/perennial#383 and phetsims/perennial#384.
It is important to have a unit test harness for the node side of things.
The text was updated successfully, but these errors were encountered: