Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT: Add tests to build/lint/tsc sims with only dependencies checked out #202

Closed
zepumph opened this issue Jan 17, 2024 · 2 comments
Closed

Comments

@zepumph
Copy link
Member

zepumph commented Jan 17, 2024

From phetsims/perennial#347. We lint/tsc on release branches, and it would be best to be testing this when only dependencies are checked out. It would caught phetsims/phetcommon#63 eagerly, and also aligns with open source/POSE related goals.

@zepumph
Copy link
Member Author

zepumph commented Jan 17, 2024

phetsims/perennial#347 (comment) is a bad first patch. Likely going fresh is best.

@zepumph
Copy link
Member Author

zepumph commented Jan 23, 2024

While this would be helpful, it doesn't seem valuable enough to create so much space burden (perhaps 2 orders of magnitude more space with 100 copies of chipper/node_modules/dist checked out).

I'm going to close this issue as a wontfix, and we can pick things up in #203. That issue will at least catch this once the release branch is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant