Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot comparison improvements #122

Open
3 tasks
zepumph opened this issue Mar 20, 2021 · 2 comments
Open
3 tasks

Snapshot comparison improvements #122

zepumph opened this issue Mar 20, 2021 · 2 comments

Comments

@zepumph
Copy link
Member

zepumph commented Mar 20, 2021

While using the snapshot comparison tool to check on phetsims/sun#631, I had the following thoughts on improvements:

  • Add a button next to "Start Snapshot" that only reruns the items that had an error on last snapshot
  • Speedup the tool by either loading more sims in more iframes at a time, or kicking off the loading of the next iframe once the first iframe is loaded and is being fuzzed.
  • Button to clear all snapshots images that you have clicked up.

Tagging @jonathanolson to see if he has qualms about these thoughts, or wants to add more.

@zepumph zepumph self-assigned this Mar 20, 2021
@jonathanolson
Copy link
Contributor

All of that sounds great. Feel free to rebuild the interface/UI/handling completely, or make whatever changes. It's in a pretty rough state.

@zepumph
Copy link
Member Author

zepumph commented Apr 5, 2023

@chrisklus just had such an amazing idea that I'd like to try out

  • Have a "manual mode", likely for just a single sim, where the sim loads, and you put it into a state, and then "take snapshot", then have another button that reloads to let you put the new version into that same mode before pressing again "take snapshot", it may be best as a second html page using much the same code. Thanks @chrisklus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants