Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MedicalAction action field in doc could be changed to a more detailed field #347

Open
belkassaby opened this issue Aug 22, 2022 · 2 comments

Comments

@belkassaby
Copy link

In MedicalAction, there is the "action" field which can be either of type Procedure, Treatment, RadiationTherapy or TherapeuticRegimen. Instead of it being named "action" (in a phenopacket json file that is generated with the phenopacket-tools, there is no such field/id), we could indicate that the id in the corresponding json is either "procedure", "treatment", "radiationTherapy" or "therapeuticRegimen".

@pnrobinson
Copy link
Collaborator

I do not think we want to make what would be a breaking change in the schema. Software should be able to make this obvious to users?

@belkassaby
Copy link
Author

I meant that the changes could be done in the doc instead of the software side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants