Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GA4GH Pedigree model #333

Open
julesjacobsen opened this issue Mar 3, 2022 · 10 comments
Open

Implement GA4GH Pedigree model #333

julesjacobsen opened this issue Mar 3, 2022 · 10 comments
Labels
enhancement New feature or request

Comments

@julesjacobsen
Copy link
Collaborator

julesjacobsen commented Mar 3, 2022

@buske

Will require an ethnicity field adding to Individual:

Re-opening given discussion with Pedigree group on 2022-03-03. This field is useful/required for many test ordering systems. The codes used will likely be national-specific codes and not necessarily universally applicable.

Originally posted by @julesjacobsen in #231 (comment)

@julesjacobsen
Copy link
Collaborator Author

@buske - please add the link to the conceptual model docs when this has been finalised.

@julesjacobsen julesjacobsen added the enhancement New feature or request label Mar 3, 2022
@julesjacobsen
Copy link
Collaborator Author

Plan is to add org.ga4gh.pedigree.Pedigree and component classes, composed using Phenopacket-schema entities i.e. Individual, OntologyClass.

The GA4GH Pedigree would be incorporated as a oneof in the Family.pedigree field.

@julesjacobsen
Copy link
Collaborator Author

  • Implement classes
  • Update Family
  • Test backwards compatibility
  • Update Docs
  • Drink Tea

A note on backward compatibility - if it is not possible for the pedigree to be made a oneof we will have to try another solution.

@pnrobinson
Copy link
Collaborator

@julesjacobsen I think this is something we will have to leave for a future version? Should we close?

@M-casado
Copy link

Hi everyone, sorry to budge in this thread, but I was wondering if you could give more details about the future population building block. I came from #231, and I also am interested in having ethnicity part of a phenopacket.

Regardless of what the final implementation is, would it include both ancestry informative markers (Ancestry category [HANCESTRO:0004]) and other less informative markers (in case the former are missing; e.g. National origin [NCIT:C28407] or Ethnic group [EFO:0001799]).

@julesjacobsen
Copy link
Collaborator Author

Currently 727b245

This is external to the phenopacket-schema as it lives in the org.ga4gh.pedigree namespace and imports Phenopacket and OntologyClass . This might change to use the Pedigree model Individual and potentially a Concept (would be identical to OntologyClass, only native to the Pedigree model to reduce depencencies)

@julesjacobsen
Copy link
Collaborator Author

@M-casado have you got a use-case and model in mind? If so please continue this in #231

@M-casado
Copy link

Hi @julesjacobsen, I do not a specific use-case and model in mind. There is a general desire from the users of my archive (EGA) to be able to provide the ethnicity of their probands, and we will try to conform to phenopackets.

@cmungall cmungall mentioned this issue May 13, 2024
@cmungall
Copy link
Member

What's the status of this?

@julesjacobsen
Copy link
Collaborator Author

This is work in progress and taking lead from the GA4GH-Pedigree working group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants