Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve statistics command line flag #357

Open
phate opened this issue Jan 20, 2024 · 1 comment
Open

Improve statistics command line flag #357

phate opened this issue Jan 20, 2024 · 1 comment

Comments

@phate
Copy link
Owner

phate commented Jan 20, 2024

The statistics command line flags for jlc and jlm-opt are very verbose and partly non-descriptive. The following should be done:

  1. Improve the descriptiveness of the statistics command line flags. They should describe/reflect the (optimization) pass they are gathering statistics for.
  2. We should transform the statistics flag into a comma separated list: --statistics=statistics1, statistics2,...
@haved
Copy link
Collaborator

haved commented Jan 20, 2024

The duplication I was referencing is the set of statistics options listed both at
https://github.com/phate/jlm/blob/master/jlm%2Ftooling%2FCommandLine.cpp#L512

and

https://github.com/phate/jlm/blob/master/jlm%2Ftooling%2FCommandLine.cpp#L771

Which can be nicely deduplicated by replacing the individual command line flags by a single comma separated string.

Also, the mapping between StatisticsId and statistic name can use a BiMap :)

phate added a commit that referenced this issue Feb 8, 2024
We had a lot of unnecessary code for setting up the statistics command
line options of jlm-opt and jlc. This PR simplifies it. It is part of
#357.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants