-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tree list for navigation to apps and envs in the sidebar #265
Comments
@rohan-chaturvedi I would like to take up this issue below is a basic mockup design, I will be handling overflows using tailwind properties of overflow, Also there will be a highlight on the active app and its staging where user is present. |
Sounds good, @DhairyaMajmudar! |
Thanks can you pls. assign |
hey @rohan-chaturvedi can I work on this issue? |
All yours, @harshith-1008 ! |
@muntaxir4 perhaps you could collaborate on it with @harshith-1008? You'll need to check with him though, as I've assigned him the issue. |
hi @muntaxir4, I have also started working on this issue. If you don't mind can you take up another unassigned issue if possible? Or we could just both attempt it and after reviewing maybe the best PR could be merged? thank you for understanding . |
@harshith-1008 Okay, since you were assigned first, you can continue working on it. I will go with some other issue. |
@rohan-chaturvedi This is my progress, I have not finished the entire tree system yet, but just wanted to ask if I should proceed with this UI? |
Also, can you please suggest how to fetch the environments(dev, prod) of a particular app so that I can display them in sidebar? When the user clicks on a particular env of an app it should redirect it to that environments' page right? but how do I add routing/link if I don't have the Id of that env in the sidebar? |
@harshith-1008 a couple of suggestions:
|
@rohan-chaturvedi can you please help me with this? |
Hey @harshith-1008 , you can use this GetAppEnvironments query to fetch environments for a specific App. You could create a new operation that fetches all envs for a list of app ids too. |
Hey @rohan-chaturvedi , I have tried using GetAppEnvironments but I am facing an issue in there I need all the app environments data, but for the query I can only pass a single ID, could you suggest me how I can get all the app environments data. |
@harshith-1008 You could either modify the existing query or create a new query that accepts a list of Another approach is to extend the apps {
id
name
environments {
id
name
}
} In case you plan to modify the existing |
Great! Let's try and replicate the tree like UI, with branch lines. Alternatively, you could try and use the collapsing ui from the sidebar in https://docs.phase.dev. For active app and env, let's tone down the visual effect slightly. Just use a heavier font weight, or a brighter color. |
@harshith-1008 Here's a high fidelity mock that should help:
Here's the Figma for this too, in case it helps. |
The entire menu is closed by default, only when clicking on "V" its expanded but when I click on other sidebar links it stays expanded and only collapses on second click of "V". Also clicking on apps takes you to the apps home screen as you wish, I am just working on the design would you like anything else? |
That sounds good! Will review the details of the design and UX once we have a PR. |
Is your feature request related to a problem?
Navigating to an app and environment requires several clicks.
Describe the solution you'd like
Add a tree list of apps and envs in the sidebar that the user has access to. Under the "Apps" item:
![image](https://private-user-images.githubusercontent.com/6710327/337622428-6f362a3a-5b3b-4402-a5f9-4584e9460632.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMTczNzcsIm5iZiI6MTczOTExNzA3NywicGF0aCI6Ii82NzEwMzI3LzMzNzYyMjQyOC02ZjM2MmEzYS01YjNiLTQ0MDItYTVmOS00NTg0ZTk0NjA2MzIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMTYwNDM3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NGI4MDI2ZDgwMTM2MzAxMjJjODkxMjFiNDA2ZWEyZTAzOTY5ZjQwZjQ4ODg3NTJmYzUwYTA0MDNkOThlYzFiNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.EqbSkUVOHbiITK7Myn49cJ2lH3tSf3-m_1DDeZMd4Xg)
The text was updated successfully, but these errors were encountered: