Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a menu / screen to manage tags #124

Open
rohan-chaturvedi opened this issue Nov 18, 2023 · 9 comments
Open

Add a menu / screen to manage tags #124

rohan-chaturvedi opened this issue Nov 18, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request fosshack Issues for FOSS Hack 2024 frontend Change in frontend code

Comments

@rohan-chaturvedi
Copy link
Member

Is your feature request related to a problem?

Currently tags can be created organisation wide, but cannot be edited or deleted.

Describe the solution you'd like

A screen that allows editing and deleting tags. UI inspiration:

Screenshot from 2023-11-18 14-21-10

@rohan-chaturvedi rohan-chaturvedi added enhancement New feature or request frontend Change in frontend code labels Nov 18, 2023
@rohan-chaturvedi rohan-chaturvedi added the fosshack Issues for FOSS Hack 2024 label Jun 7, 2024
@SuryatejPonnapalli
Copy link

I would like to work on this issue!! @rohan-chaturvedi

@rohan-chaturvedi
Copy link
Member Author

I would like to work on this issue!! @rohan-chaturvedi

Sure, its all yours!

@SuryatejPonnapalli
Copy link

Screenshot 2024-07-27 at 12 41 00 PM

@rohan-chaturvedi is it fine if I keep tags manage button here? or should I try to put it somewhere in the tagsDialgue? and also is there any query to edit or delete a tag?

@rohan-chaturvedi
Copy link
Member Author

@SuryatejPonnapalli let's put it in the tags dialog, in a separate "Manage tags dialog". You'll need to add queries and mutations to edit and delete tags.

@SuryatejPonnapalli
Copy link

Screenshot 2024-07-27 at 4 02 54 PM Screenshot 2024-07-27 at 4 03 22 PM

@rohan-chaturvedi is this UI fine to manage tags? Actually am not familiar with drf/graphQL, can you share any reference/docs that I can look into to write new queries and mutations?

@rohan-chaturvedi
Copy link
Member Author

That looks great! How will the edit action work?

Fastest way to get familiar with mutations is to check out how existing ones are written, such as the CreateSecretTagMutation. Write a similar mutation for edit and delete, and add them to the schema

You can also check out the docs for Graphene Django

@SuryatejPonnapalli
Copy link

onClick it will open a modal in which user has option to edit the tag and on confirming the change, it will get updated. do you have any other suggestions or requirements in your mind?

@rohan-chaturvedi
Copy link
Member Author

That could work, except we are already using a modal nested in another modal 😅

What if we allowed editing the tag name and color in place? In your UI, clicking the 'edit' button would make the tag text editable, and allow clicking the color dot to open the color picker. If any changes have been made to a tag, replace the 'edit' button with a 'save' button to save changes.

@SuryatejPonnapalli
Copy link

thanks for the suggestion ill try to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fosshack Issues for FOSS Hack 2024 frontend Change in frontend code
Projects
None yet
Development

No branches or pull requests

2 participants