Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outerMostContext seems to be wrongly used #86

Open
MarcusDenker opened this issue Oct 20, 2023 · 0 comments
Open

outerMostContext seems to be wrongly used #86

MarcusDenker opened this issue Oct 20, 2023 · 0 comments

Comments

@MarcusDenker
Copy link
Contributor

Sindarin is the only user of #outerMostContext, a method that does not really seem to make sense... especially if one looks at the code that uses is:

SindarinDebugger>>#canStillExecute:

	rightContext == rightContext outerMostContext or: [
		rightContext method ast allChildren identityIncludes: aProgramNode ] ]
		whileFalse: [ rightContext := rightContext sender ].

So this check if the right context is the outerMostContext (defined by walking up the outerContext chain), but what it then does it to walk up the sender chain.

outerMostContext 
	^ self outerContext
		ifNil: [ self ]
		ifNotNil: [ self outerContext ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant