Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having good styles for Microdown rendered comments in light theme #16394

Closed
Ducasse opened this issue Apr 2, 2024 · 9 comments
Closed

Having good styles for Microdown rendered comments in light theme #16394

Ducasse opened this issue Apr 2, 2024 · 9 comments
Assignees
Labels
To fix before release Issure to fix before the upcoming Pharo release

Comments

@Ducasse
Copy link
Member

Ducasse commented Apr 2, 2024

In light theme class comment are barely readable.
It gives the feeling that we did not care. Here we cannot read the classes in the hiearchy

Capture 2024-04-02 at 15 29 22

@Ducasse Ducasse added the To fix before release Issure to fix before the upcoming Pharo release label Apr 2, 2024
@Ducasse
Copy link
Member Author

Ducasse commented Apr 2, 2024

Or we can simply remove the light theme.

@hernanmd
Copy link
Member

hernanmd commented Apr 3, 2024

Could you update the following method with the code here and send me a screenshot or tell me if it does look right for you?

MicTextStyler >> #monospaceBackgroundColor
	^ Smalltalk ui theme settings windowColor muchLighter

This is what it looks like on my screen.

Screenshot 2024-04-03 at 17 10 23

@hernanmd hernanmd self-assigned this Apr 3, 2024
@jecisc
Copy link
Member

jecisc commented Apr 3, 2024

Did you also check with the dark theme?

@hernanmd
Copy link
Member

hernanmd commented Apr 3, 2024

Did you also check with the dark theme?

I never use dark theme but I tried and if dark theme is used, then my "update" should be muchDarker instead of muchLighter

@estebanlm
Copy link
Member

we can't remove light theme :)
now the problem is that the "code" block (this is how the hierarchy and links are made) is rendered with a background that is not very appealing. Honestly I would put it just transparent (no need to have it differentiate)

@Ducasse
Copy link
Member Author

Ducasse commented Apr 4, 2024

Agreed it sucks. So we do a lot to improve and the last 2 % may kill us.

@hernanmd
Copy link
Member

hernanmd commented Apr 5, 2024

Surprisingly, if you change the color to transparent and hover the mouse over a microdown text with monospace, you get this error...

Screenshot 2024-04-05 at 15 59 34

I think it would be better to have a minimum variation of transparent because I don't know what the code is actually checking

@hernanmd
Copy link
Member

hernanmd commented Apr 5, 2024

Ok, PR in pillar-markup/Microdown#701

@jecisc
Copy link
Member

jecisc commented Apr 6, 2024

Fixed in pillar-markup/Microdown#702

@jecisc jecisc closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
To fix before release Issure to fix before the upcoming Pharo release
Projects
Status: Done
Development

No branches or pull requests

4 participants