Compilation warning: Wno-unused-variable

[jordanmontt]

If one removed the warning Wno-unused-variable from the file CMakeLists.txt, at the time of compiling the generated C code, there are hundreds of warnings.

Let's take as an example the method:

genPrimitiveLoadInt32FromBytes
	^ self genPrimitiveLoad: 4 fromBytesWith: [ :sourcePointer |
		cogit MoveM32: 0 r: sourcePointer R: ReceiverResultReg.
		cogit SignExtend32R: ReceiverResultReg R: ReceiverResultReg.
		self genConvertIntegerToSmallIntegerInReg: ReceiverResultReg.
		cogit  ].

When inlininng, The variable sourcePointer becomes not used and it is replaced (see cogitaarch64.c:21349) by Arg1Reg. This is logical since in the Pharo method genPrimitiveLoadInt32FromBytes, the block sourcePointer was called with Arg1Reg.

Possible solution
It will be nice to improve the inlining algorithm of Slang to clean the non used variables. Because fixing this in the Pharo code can be too time-consuming as there are hundreds of warning and some of them, like the one on the example, are not easy to spot nor to fix