Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory game disappear animation leaves ghosts #12

Open
cdlm opened this issue Apr 21, 2023 · 2 comments
Open

Memory game disappear animation leaves ghosts #12

cdlm opened this issue Apr 21, 2023 · 2 comments

Comments

@cdlm
Copy link

cdlm commented Apr 21, 2023

When you find a pair, cards are animated scaling smaller and getting transparent.
They're supposed to become fully invisible but they don't, and the ghost cards left behind are still interactive.

Solved memory game with zombie cards

In the screenshot, the game is fully solved. The small square in the rightmost column is an example of a card that didn't fully disappear. There are other smaller ones in the first row. The code is supposed to scale the cards down to 1% of their full size which is much smaller than that.

The two big ghost cards in the middle are what you get by clicking those tiny squares.

To me this suggests either that the animation stops before it's really finished, or that when it stops it doesn't get a chance to update the card elements to their final state.

@tinchodias
Copy link
Contributor

This is probably the same cause as this bug: pharo-graphics/Bloc#194

@cdlm
Copy link
Author

cdlm commented May 5, 2023

Indeed, that's quite possible. It's like the penultimate frame is drawn, the animation finishes before the next one, and there should be (but actually isn't) an additional frame drawn to show the final state of the animation even if it's drawn a bit late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants