Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renaming event methods #178

Open
Enzo-Demeulenaere opened this issue Jul 16, 2024 · 1 comment
Open

renaming event methods #178

Enzo-Demeulenaere opened this issue Jul 16, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@Enzo-Demeulenaere
Copy link

the method leavedSkinEvent: isn't grammatically correct and should be renamed leftSkinEvent: if we keep the past tense or we could go for the present tense with leaveSkinEvent: ( this would required renaming all similar methods hoveredSkinEvent: -> hoverSkinEvent:)
@labordep labordep added the documentation Improvements or additions to documentation label Jul 19, 2024
@plantec
Copy link
Collaborator

plantec commented Sep 28, 2024

ah yes thanks
i will change to leftSkinEvent
changing all method name could be done but it takes time to change all related class and method names

@plantec plantec added the question Further information is requested label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@plantec @labordep @Enzo-Demeulenaere