Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add/Update SDTM test data for {admiralpeds} #88

Closed
rossfarrugia opened this issue Feb 12, 2024 · 6 comments · Fixed by #115
Closed

Feature Request: Add/Update SDTM test data for {admiralpeds} #88

rossfarrugia opened this issue Feb 12, 2024 · 6 comments · Fixed by #115
Labels
enhancement New feature or request Post 1.0 release

Comments

@rossfarrugia
Copy link
Contributor

Feature Idea

Add/Update SDTM test data for {admiralpeds}

Relevant Input

N/A

Relevant Output

N/A

Reproducible Example/Pseudo Code

N/A

@rossfarrugia rossfarrugia added the enhancement New feature or request label Feb 12, 2024
@manciniedoardo
Copy link
Collaborator

@rossfarrugia we would like to release pharmaversesdtm 1.0 at the start of June. Will the test data be ready by then? Otherwise would need to add in a later release and temporarily keep in admiralpeds.

@rossfarrugia
Copy link
Contributor Author

@manciniedoardo - @kabis-ops has created this at https://github.com/pharmaverse/admiralpeds/tree/main/data - see dm_peds and vs_peds, and programs at https://github.com/pharmaverse/admiralpeds/tree/main/data-raw. But I just quickly looked and this hasn't been created as an extension of the CDISC pilot study data so wouldn't be fit to go in pharmaversesdtm yet without some re-work. e.g. new subject IDs have been created as "PEDS-1001" for example rather than building on those dummy subjects in pharmaversesdtm DM. I would go ahead with your planned release for June and assume that we'd move these over later.

@manciniedoardo
Copy link
Collaborator

Thanks @rossfarrugia - I will label this issue as Post 1.0. Perhaps it would be good then to also make a companion issue (and link to this one) on the admiralpeds side for when you do have a chance to move the data over.

@rossfarrugia
Copy link
Contributor Author

yes we have it here pharmaverse/admiralpeds#36, will let you know if anything changes. We might be able to squeeze it in earlier as its impacting our template/vignette anyway as we don't have an ADSL matching these patients as they are now.

@rossfarrugia
Copy link
Contributor Author

rossfarrugia commented May 28, 2024

I think this one can stay open for now and we'll move these datasets over after we do admiralpeds 0.1.0 release in July. It corresponds now to this issue pharmaverse/admiralpeds#40

@kaz462
Copy link
Contributor

kaz462 commented May 28, 2024

I think this one can stay open for now and we'll move these datasets over after we do admiralpeds 0.1.0 release in July. It corresponds now to this issue pharmaverse/admiralpeds#40

Thanks for re-opening. It was linked to the wrong PR and got closed when that PR was merged, all good now.

@rossfarrugia rossfarrugia linked a pull request Aug 28, 2024 that will close this issue
14 tasks
Fanny-Gautier added a commit that referenced this issue Sep 13, 2024
manciniedoardo added a commit that referenced this issue Oct 9, 2024
Closes #88 Use pharmaversesdtm to host admiralpeds test data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Post 1.0 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants