Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up scripts #39

Closed
kaz462 opened this issue Jul 19, 2023 · 1 comment · Fixed by #46
Closed

Clean up scripts #39

kaz462 opened this issue Jul 19, 2023 · 1 comment · Fixed by #46
Assignees
@manciniedoardo

Comments

@kaz462
Copy link
Contributor

kaz462 commented Jul 19, 2023 

          Thanks for working on this @kaz462 - there are a few things I would change in the individual scripts to make them tidier and more homogeneous, but as discussed yesterday for nowit's more important to get the package structure nailed down.

Originally posted by @manciniedoardo in #38 (comment)
@manciniedoardo manciniedoardo self-assigned this Jul 20, 2023
@kaz462
Copy link
Contributor Author

kaz462 commented Aug 2, 2023

consistent way to save the data: change save(xx, file = "data/xx.rda", compress = "bzip2") to usethis::use_data(xx)

@kaz462 kaz462 mentioned this issue Aug 2, 2023
Merged
14 tasks
@manciniedoardo manciniedoardo mentioned this issue Aug 8, 2023
Merged
14 tasks
manciniedoardo added a commit that referenced this issue Aug 8, 2023
@manciniedoardo
#39 chore: styler
4a33302
manciniedoardo added a commit that referenced this issue Aug 9, 2023
@manciniedoardo
#39 data rerun with new labels
5a0932c
@kaz462 kaz462 closed this as completed in #46 Aug 9, 2023
kaz462 added a commit that referenced this issue Aug 9, 2023
@manciniedoardo @kaz462
Closes #39 cleaned up script commenting, structure of scripts for con…
2f6bc1b 
…sistency (#46)

* # 39 cleaned up commenting and structure of scripts to make them more consistent

* #39 chore: styler

* Update data-raw/pc.R

Co-authored-by: Kangjie Zhang <[email protected]>

* Update data-raw/pp.R

Co-authored-by: Kangjie Zhang <[email protected]>

* Update data-raw/rs_onco.R

Co-authored-by: Kangjie Zhang <[email protected]>

* Update data-raw/tr_onco.R

Co-authored-by: Kangjie Zhang <[email protected]>

* Update data-raw/ts.R

Co-authored-by: Kangjie Zhang <[email protected]>

* Update data-raw/tu_onco.R

Co-authored-by: Kangjie Zhang <[email protected]>

* Update data-raw/ae.R

Co-authored-by: Kangjie Zhang <[email protected]>

* Update data-raw/dm.R

Co-authored-by: Kangjie Zhang <[email protected]>

* Update data-raw/ds.R

Co-authored-by: Kangjie Zhang <[email protected]>

* Update data-raw/tr_onco.R

Co-authored-by: Kangjie Zhang <[email protected]>

* #39 data rerun with new labels

---------

Co-authored-by: Kangjie Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manciniedoardo manciniedoardo

Labels
None yet
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
2 participants
@kaz462 @manciniedoardo