Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict computation of CHG and PCHG to post-baseline records only #95

Open
Fanny-Gautier opened this issue Sep 23, 2024 · 3 comments · May be fixed by #96
Open

Restrict computation of CHG and PCHG to post-baseline records only #95

Fanny-Gautier opened this issue Sep 23, 2024 · 3 comments · May be fixed by #96
Assignees
@remikk

Comments

@Fanny-Gautier
Copy link
Contributor

Background Information

CHG and PCHG computation have been updated in templates and vignettes of {admiral} in order to compute them only for post- baseline records. This is what is usually expected for these 2 parameters. A note has also been added to notify that this computation rule is left to the producer choice. See issue #2484 and it's corresponding PR

Definition of Done

Procced with the same in {admiralpeds} template and vignette:
Use restrict_derivation() while deriving CHG and PCHG and add a note explaining the rational of this update.
@rossfarrugia
Copy link
Collaborator

@remikk this is a good issue for you to help with. you can follow similar to what was done for admiral core package as linked above. let me and Fanny know if any issue

@remikk
Copy link
Contributor

remikk commented Sep 28, 2024

@Fanny-Gautier @rossfarrugia Sure, thank you for the assignment. I will take care of the issue.

@rossfarrugia
Copy link
Collaborator

thanks @remikk - you can tag us both as reviewers once the PR is ready

@remikk remikk linked a pull request Sep 30, 2024 that will close this issue
Update ad_advs.R #96
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remikk remikk

Labels
None yet
Projects
admiralpeds
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ad_advs.R pharmaverse/admiralpeds
3 participants
@remikk @rossfarrugia @Fanny-Gautier