Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ad_advs.R #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update ad_advs.R #96

wants to merge 1 commit into from

Conversation

remikk
Copy link
Contributor

@remikk remikk commented Sep 30, 2024 •
edited
Loading

Closes #96
The CHG and PCHG derivations were restricted to the post-baselines visits using restrict_derivation() with AVISITN > 0 condition as in the referenced #2484 in pharmaverse/admiral repository.

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiralpeds (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiralpeds site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@remikk
Update ad_advs.R
a66fc69 
The CHG and PCHG derivations were restricted to the post-baselines visits using restrict_derivation() with AVISITN > 0 condition as in the referenced #2484 in pharmaverse/admiral repository.
@remikk remikk linked an issue Sep 30, 2024 that may be closed by this pull request
Restrict computation of CHG and PCHG to post-baseline records only #95
Open
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
admiralpeds 99% ✔
Summary 99% (267 / 271) ✔

@rossfarrugia
Copy link
Collaborator

Thanks @remikk - the code change looks good to me.

You now need to work through the above PR checklist ticking them all off, e.g. update PR title to include "closes #<issue_number>" and add a sentence to the NEWS.md file for this update. For this you should add something at the top like:

# admiralpeds (development version)

## Updates of Existing Functions

- `ADVS` template updated in line with {admiral} to calculate change from baseline variables only for post-baseline records (#95).

Fanny-Gautier
Fanny-Gautier approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@Fanny-Gautier Fanny-Gautier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Please apply Ross' comments and it will be ready to finalize this PR.

@remikk
Copy link
Contributor Author

remikk commented Oct 16, 2024

Hi @Fanny-Gautier and @rossfarrugia
Thank you for the reminder.
Yes, I will finalise this PR today.

@rossfarrugia rossfarrugia mentioned this pull request Oct 28, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fanny-Gautier Fanny-Gautier Fanny-Gautier approved these changes

@rossfarrugia rossfarrugia Awaiting requested review from rossfarrugia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrict computation of CHG and PCHG to post-baseline records only
3 participants
@remikk @rossfarrugia @Fanny-Gautier