Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Issue: derive_var_studyeye() accidentally uses hardcoded subject keys #254

Open
manciniedoardo opened this issue Oct 23, 2024 · 1 comment
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@manciniedoardo
Copy link
Collaborator

Background Information

  derive_vars_merged(
    dataset_adsl,
    dataset_add = dataset_sc,
    by_vars = exprs(STUDYID, USUBJID), 
    order = NULL,
    filter_add = SCTESTCD == !!sctestcd_value,
    new_vars = exprs(STUDYEYE = SCSTRESC),
    mode = NULL,
    missing_values = exprs(STUDYEYE = "")
  ) 

Should be:

  derive_vars_merged(
    dataset_adsl,
    dataset_add = dataset_sc,
    by_vars = get_admiral_option("subject_keys"),
    order = NULL,
    filter_add = SCTESTCD == !!sctestcd_value,
    new_vars = exprs(STUDYEYE = SCSTRESC),
    mode = NULL,
    missing_values = exprs(STUDYEYE = "")
  ) 

Definition of Done

Replace problematic line!

@manciniedoardo manciniedoardo added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 23, 2024
@manciniedoardo
Copy link
Collaborator Author

@steventing12 mind knocking this one out too please? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants