Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ADBCVA vignette, template to use new {admiral} AVALCAT derivation function #244

Open
manciniedoardo opened this issue Sep 12, 2024 · 2 comments
Open

Update ADBCVA vignette, template to use new {admiral} AVALCAT derivation function #244

manciniedoardo opened this issue Sep 12, 2024 · 2 comments
Assignees
@steventing12

Comments

@manciniedoardo
Copy link
Collaborator

Background Information

Currently there is nothing specific in {admiral} for AVALCAT derivation so ADBCVA template and vignette just go about it using tidyverse tools. This will change once the functionality is added to {admiral} - see here.

Definition of Done

Update template and vignette to use new {admiral} function.
steventing12 added a commit that referenced this issue Oct 21, 2024
@steventing12
feat: #244 Used derive_vars_cat() to derive AVALCA1N and AVALCAT1, re…
84bfcac 
…placing look-up table with derive_vars_merged()

feat: #247 Used call_derivation with derive_vars_crit_flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl()
@steventing12
Copy link
Collaborator

Used derive_vars_cat() to derive AVALCA1N and AVALCAT1, replacing look-up table with derive_vars_merged(). However, the input expression is still duplicating conditions for SBCVA and FBCVA as a combining expressions doesn't yield the same structure.

@manciniedoardo
Copy link
Collaborator Author

Can you please make a pull request with your proposed changes? That way I can review code/changes and propose amendments.

@steventing12 steventing12 linked a pull request Oct 22, 2024 that will close this issue
Closes #244: introduction of derive_vars_cat() #252
Closed
14 tasks
@manciniedoardo manciniedoardo mentioned this issue Oct 23, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steventing12 steventing12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #244: introduction of derive_vars_cat() pharmaverse/admiralophtha
2 participants
@manciniedoardo @steventing12