Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next stage of deprecation cycle for derive_var_afeye() arguments #237

Open
manciniedoardo opened this issue Jun 10, 2024 · 0 comments · May be fixed by #251
Open

Next stage of deprecation cycle for derive_var_afeye() arguments #237

manciniedoardo opened this issue Jun 10, 2024 · 0 comments · May be fixed by #251
Assignees

Comments

@manciniedoardo
Copy link
Collaborator

Background Information

lat_vals and dataset_occ argument now need to be totally removed as we are in Phase 3 of the deprecation cycle

Note: This issue can be started after the 1.1 release in June 2024

Definition of Done

  • lat_vals and dataset_occ argument totally removed from derive_var_afeye() function code
  • run devtools::document() to update function documentation
  • tests that check for deprecation of these arguments deleted
  • NEWS.md updated to say that these arguments have reached the final stage of the deprecation cycle and have now been deleted
@manciniedoardo manciniedoardo changed the title Next stage of deprecation cycle for derive_var_afeye() arugments Next stage of deprecation cycle for derive_var_afeye() arguments Jul 23, 2024
@ukey1025 ukey1025 self-assigned this Jul 30, 2024
ukey1025 pushed a commit that referenced this issue Oct 8, 2024
@manciniedoardo manciniedoardo linked a pull request Oct 21, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants